Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add v2 frontend UI design #261

Merged
merged 1 commit into from
Aug 21, 2024
Merged

feat: add v2 frontend UI design #261

merged 1 commit into from
Aug 21, 2024

Conversation

kittybest
Copy link
Contributor

@kittybest kittybest commented Aug 14, 2024 •
edited
Loading

Description

  • modify homepage
  • add round information
  • remove unused environment variables
  • read roundId from website url instead of adding to the page props
  • rearrange the folder structure, since the projects/ballot should be inside the rounds

Notice
This branch would be merged to dev instead of main since the round data are fake data now, just for frontend UI/UX testing, we should get the round data from the registry contract later.

@vercel Vercel
Copy link

vercel bot commented Aug 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-platform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 6:24pm

@kittybest kittybest force-pushed the feat/design-v2 branch 2 times, most recently from 900e26e to ac174de Compare August 15, 2024 19:35
@kittybest kittybest changed the base branch from main to dev August 19, 2024 19:28
@kittybest kittybest marked this pull request as ready for review August 20, 2024 12:38
0xmad
0xmad requested changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kittybest thanks, there are some comments

packages/interface/src/components/Header.tsx Outdated Show resolved Hide resolved
packages/interface/src/contexts/Round.tsx Outdated Show resolved Hide resolved
packages/interface/src/contexts/Round.tsx Outdated Show resolved Hide resolved
packages/interface/src/contexts/Round.tsx Show resolved Hide resolved
packages/interface/src/pages/index.tsx Outdated Show resolved Hide resolved
packages/interface/src/providers/index.tsx Show resolved Hide resolved
0xmad
0xmad approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kittybest thanks!

@kittybest kittybest merged commit e2e6968 into dev Aug 21, 2024
12 checks passed
@kittybest kittybest deleted the feat/design-v2 branch August 21, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmad 0xmad 0xmad approved these changes

@ctrlc03 ctrlc03 Awaiting requested review from ctrlc03

@crisgarner crisgarner Awaiting requested review from crisgarner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kittybest @0xmad